[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

Tue Jan 21 09:41:57 PST 2020

xazax.hun added a comment.

In D72982#1831595 <https://reviews.llvm.org/D72982#1831595>, @hans wrote:

> Wait, do we really want the "(in-process)" marker to be written to a separate line? I'm not sure that we do.

Since the `-###` command had this property of emitting copy pastable `-cc1` invocations I would be surprised if `scan-build` would be the only tool/script to rely on this. Whatever fix we come up with I think it would be great to maintain this property.

> The change description doesn't explain how scan-build was broken or how this fixes it.
> 
> And, maybe most importantly, it seems scan-build doesn't have any tests that catches this? Should it have one?

The fact that scan-build does not have a lit-test that broke by this change is definitely a bug and we should definitely fix this. Unfortunately, no one had time to do so yet.

> 
> 
> In D72982#1831138 <https://reviews.llvm.org/D72982#1831138>, @xazax.hun wrote:
> 
>> Do you have commit access or need someone to commit on your behalf? Also, in case your change made it into the clang 10 release branch this will need to be cherry picked there as well.
> 
> 
> I've put it on my clang 10 todo list, but I'm also not sure this is the right fix, see above.

Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72982/new/

https://reviews.llvm.org/D72982