[PATCH] D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 16 15:15:06 PST 2020


sammccall added a comment.

kadir has a pending (or landed?) fix for this.

It's just a usual fragile test - it's asserting the order, but findExplicitReferences just returns the order given by targetDecls which isn't stable.

We settled on defining a stable (but arbitrary) order for targetDecl as this pattern may be replicated elsewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72883/new/

https://reviews.llvm.org/D72883





More information about the cfe-commits mailing list