[PATCH] D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS

[Jan Korous via Phabricator via cfe-commits]

This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG42b3c38903c9: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when… (authored by jkorous).
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72883/new/

https://reviews.llvm.org/D72883

Files:
  clang-tools-extra/clangd/unittests/FindTargetTests.cpp


Index: clang-tools-extra/clangd/unittests/FindTargetTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/FindTargetTests.cpp
+++ clang-tools-extra/clangd/unittests/FindTargetTests.cpp
@@ -770,6 +770,10 @@
         "1: targets = {vector}\n"
         "2: targets = {x}\n"},
        // Handle UnresolvedLookupExpr.
+       // FIXME
+       // This case fails when expensive checks are enabled.
+       // Seems like the order of ns1::func and ns2::func isn't defined.
+       #ifndef EXPENSIVE_CHECKS
        {R"cpp(
             namespace ns1 { void func(char*); }
             namespace ns2 { void func(int*); }
@@ -783,6 +787,7 @@
         )cpp",
         "0: targets = {ns1::func, ns2::func}\n"
         "1: targets = {t}\n"},
+        #endif
        // Handle UnresolvedMemberExpr.
        {R"cpp(
             struct X {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72883.238642.patch
Type: text/x-patch
Size: 888 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200116/7987e438/attachment.bin>