[PATCH] D71476: [OpenCL] Add builtin function extension handling

[Sven van Haastregt via Phabricator via cfe-commits]

svenvh marked 2 inline comments as done.
svenvh added inline comments.


================
Comment at: clang/lib/Sema/OpenCLBuiltins.td:51
+// Extension associated to a builtin function.
+class FunctionExtension<string _Ext> : AbstractExtension<_Ext>;
+
----------------
Anastasia wrote:
> Are we planning to add type extensions too? If not it might not be worth creating extra abstractions. :)
Yes, type extensions are planned.


================
Comment at: clang/lib/Sema/OpenCLBuiltins.td:1095
 // OpenCL v2.0 s9.17.3: Additions to section 6.13.1: Work-Item Functions
+def FuncExtKhrSubgroups : FunctionExtension<"cl_khr_subgroups">;
 let MinVersion = CL20 in {
----------------
Nicola wrote:
> Should this be moved together with the other extensions defined above? It might make the file easier to navigate if all the extensions are in the same place (or all close to where they are used)
I'll move it to the top for now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71476/new/

https://reviews.llvm.org/D71476