[PATCH] D71476: [OpenCL] Add builtin function extension handling

Nicola Zaghen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 17 00:38:30 PST 2019


Nicola accepted this revision.
Nicola added a comment.

Just a minor comment, can you address it before you submit? Thanks!



================
Comment at: clang/lib/Sema/OpenCLBuiltins.td:1095
 // OpenCL v2.0 s9.17.3: Additions to section 6.13.1: Work-Item Functions
+def FuncExtKhrSubgroups : FunctionExtension<"cl_khr_subgroups">;
 let MinVersion = CL20 in {
----------------
Should this be moved together with the other extensions defined above? It might make the file easier to navigate if all the extensions are in the same place (or all close to where they are used)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71476/new/

https://reviews.llvm.org/D71476





More information about the cfe-commits mailing list