[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

Eric Christopher via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 13 13:58:22 PST 2019


On Fri, Dec 13, 2019 at 1:18 PM Dávid Bolvanský via Phabricator <
reviews at reviews.llvm.org> wrote:

> xbolva00 added a comment.
>
> In D71486#1784079 <https://reviews.llvm.org/D71486#1784079>, @sammccall
> wrote:
>
> > It should be possible to test this by adapting a test case from the
> original ed8dadb <
> https://reviews.llvm.org/rGed8dadb37c7e1a7f4889d868ac9b19bfe7762237>, but
> I'm not certain...
>

> This concern was not addressed/answered.


> The commit
> https://reviews.llvm.org/rG5623bd52acd34db2e9cfc11d1510407610a14db0
> claims that this was reviewed by rsmith, but I don't see rsmith's LGTM
> here..
>
>
Both of these were handled offline: Sam mentioned just getting something in
to stop the Werror breakage in #clang on Discord and Richard was looking
over my shoulder as I was fixing up the patch.

Apologies for not following up with an email to this effect.


>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D71486/new/
>
> https://reviews.llvm.org/D71486
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191213/a1a51895/attachment-0001.html>


More information about the cfe-commits mailing list