<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Dec 13, 2019 at 1:18 PM Dávid Bolvanský via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">xbolva00 added a comment.<br>
<br>
In D71486#1784079 <<a href="https://reviews.llvm.org/D71486#1784079" rel="noreferrer" target="_blank">https://reviews.llvm.org/D71486#1784079</a>>, @sammccall wrote:<br>
<br>
> It should be possible to test this by adapting a test case from the original ed8dadb <<a href="https://reviews.llvm.org/rGed8dadb37c7e1a7f4889d868ac9b19bfe7762237" rel="noreferrer" target="_blank">https://reviews.llvm.org/rGed8dadb37c7e1a7f4889d868ac9b19bfe7762237</a>>, but I'm not certain... <br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
This concern was not addressed/answered. </blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
The commit <a href="https://reviews.llvm.org/rG5623bd52acd34db2e9cfc11d1510407610a14db0" rel="noreferrer" target="_blank">https://reviews.llvm.org/rG5623bd52acd34db2e9cfc11d1510407610a14db0</a> claims that this was reviewed by rsmith, but I don't see rsmith's LGTM here..<br>
<br></blockquote><div><br></div><div>Both of these were handled offline: Sam mentioned just getting something in to stop the Werror breakage in #clang on Discord and Richard was looking over my shoulder as I was fixing up the patch.</div><div><br></div><div>Apologies for not following up with an email to this effect.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D71486/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D71486/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D71486" rel="noreferrer" target="_blank">https://reviews.llvm.org/D71486</a><br>
<br>
<br>
<br>
</blockquote></div></div>