[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

Tue Dec 10 21:47:11 PST 2019

rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

In D71208#1776667 <https://reviews.llvm.org/D71208#1776667>, @nhaehnle wrote:

> > My concern is that there's something that's going to blow up or miscompile if we start passing in constants that aren't in a regular address space.  Aren't there kinds of annotations which get persisted into the emitted code?
>
> Annotations don't seem to be used for much at the moment in the first place. They're definitely not emitted in the resulting binary by default. Also, the only testcase in LLVM proper that has @llvm.global.annotations also happens to have addrspacecasts in there, so at least at some point in the past somebody thought it's okay to allow those casts there.

Alright, I relent.  This looks okay to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71208/new/

https://reviews.llvm.org/D71208