[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

[Nicolai Hähnle via Phabricator via cfe-commits]

nhaehnle added a comment.

> My concern is that there's something that's going to blow up or miscompile if we start passing in constants that aren't in a regular address space.  Aren't there kinds of annotations which get persisted into the emitted code?

Annotations don't seem to be used for much at the moment in the first place. They're definitely not emitted in the resulting binary by default. Also, the only testcase in LLVM proper that has @llvm.global.annotations also happens to have addrspacecasts in there, so at least at some point in the past somebody thought it's okay to allow those casts there.

Also: what's the alternative?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71208/new/

https://reviews.llvm.org/D71208