[PATCH] D69223: WDocumentation: Implement the \anchor.

[Mark de Wever via Phabricator via cfe-commits]

Mordante marked 6 inline comments as done.
Mordante added inline comments.


================
Comment at: clang/lib/Index/CommentToXML.cpp:650
+    assert(C->getNumArgs() == 1);
+    Result << "<anchor>";
+    appendToResultWithXMLEscaping(Arg0);
----------------
gribozavr2 wrote:
> Sholudn't this code be producing "<anchor id=...>"?
Good catch, will update it in the next patch.


================
Comment at: clang/test/Index/Inputs/CommentXML/valid-inline-command-01.xml:1
+<?xml version="1.0" encoding="utf-8"?>
+<Namespace>
----------------
gribozavr2 wrote:
> Please add a line to `clang/test/Index/comment-xml-schema.c` that executes this test.
I already added a line.


================
Comment at: clang/test/Index/comment-xml-schema.c:38
+// RUN: xmllint --noout --relaxng %S/../../bindings/xml/comment-xml-schema.rng %S/Inputs/CommentXML/valid-inline-command-01.xml
 
 // RUN: not xmllint --noout --relaxng %S/../../bindings/xml/comment-xml-schema.rng %S/Inputs/CommentXML/invalid-function-01.xml 2>&1 | FileCheck %s -check-prefix=CHECK-INVALID
----------------
Is this what you meant? Or did you mean something different?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69223/new/

https://reviews.llvm.org/D69223