[PATCH] D69223: WDocumentation: Implement the \anchor.

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr2 added a comment.

A few more comments, but generally looks good!



================
Comment at: clang/include/clang-c/Documentation.h:188
+  /**
+   * Command argument should not be rendered (since it is a only defines
+   * an anchor).
----------------
"since it is a only" => "since it only"


================
Comment at: clang/lib/Index/CommentToXML.cpp:650
+    assert(C->getNumArgs() == 1);
+    Result << "<anchor>";
+    appendToResultWithXMLEscaping(Arg0);
----------------
Sholudn't this code be producing "<anchor id=...>"?


================
Comment at: clang/test/Index/Inputs/CommentXML/valid-inline-command-01.xml:1
+<?xml version="1.0" encoding="utf-8"?>
+<Namespace>
----------------
Please add a line to `clang/test/Index/comment-xml-schema.c` that executes this test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69223/new/

https://reviews.llvm.org/D69223