[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 2 02:05:14 PST 2019


ilya-biryukov added a comment.

Another interesting consideration: we choose to ask users to whitelists compilers we might run from `compile_commands.json` that we can.
We are in a better position here, since we're not running the binaries based on user input.

Technically, we could consider using the same mechanism for running `xcrun`. It will probably never be used in practice, though (and we'll have to whitelist some common `xcrun` binaries anyway).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70863/new/

https://reviews.llvm.org/D70863





More information about the cfe-commits mailing list