[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 2 00:52:00 PST 2019


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:135
+    // On other platforms, just look for compilers on the PATH.
+    for (const char* Name : {"clang", "gcc", "ccc"})
+      if (auto PathCC = llvm::sys::findProgramByName(Name))
----------------
ilya-biryukov wrote:
> NIT: maybe add braces to the for statement?
did you mean "cc" instead of "ccc"? or is that really a think ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70863/new/

https://reviews.llvm.org/D70863





More information about the cfe-commits mailing list