[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

[Alex Lorenz via Phabricator via cfe-commits]

arphaman added inline comments.


================
Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:97
+      if (OutputPaths.empty())
+        OutputPaths = Opts.Targets;
       Dependencies.push_back(File);
----------------
Bigcheese wrote:
> arphaman wrote:
> > What if `Opts.Targets` is empty?
> If I recall correctly, `Opts.Targets` can never be empty. I gets set to `<basename>.o` if it would be empty.
What I mean is, what if the client didn't request a dependency file in the original compilation command? ScanDeps worker currently has a fake `"clang-scan-deps dependency"` target that it adds if the target is empty, but I do't think that should be reported as an output file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70268/new/

https://reviews.llvm.org/D70268