[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.
Michael Spencer via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 21 15:06:38 PST 2019
Bigcheese marked an inline comment as done.
Bigcheese added inline comments.
================
Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:97
+ if (OutputPaths.empty())
+ OutputPaths = Opts.Targets;
Dependencies.push_back(File);
----------------
arphaman wrote:
> What if `Opts.Targets` is empty?
If I recall correctly, `Opts.Targets` can never be empty. I gets set to `<basename>.o` if it would be empty.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70268/new/
https://reviews.llvm.org/D70268
More information about the cfe-commits
mailing list