[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

[Ben D. Jones via cfe-commits]

Yup will do. 

Sent from my iPhone

- Ben D. Jones

> On Nov 19, 2019, at 6:32 PM, Akira Hatanaka <ahatanaka at apple.com> wrote:
> 
> Can you check the `#0` at the end of the globals and other strings that precede that? If you do so, we can also check that `no_dead_strip` isn’t added.
> 
>> On Nov 19, 2019, at 6:05 PM, Duncan P. N. Exon Smith via Phabricator via cfe-commits <cfe-commits at lists.llvm.org> wrote:
>> 
>> dexonsmith added a comment.
>> 
>> For some reason this revision is locked down and I'm not allowed to "edit" it, which includes adding inline review comments.  Can you add me as a reviewer?
>> 
>> The two comments:
>> 
>> - Please add a period at the end of the sentence in the comment.
>> - Can you give more context about what `objc_arc_inert` is doing, and why it's necessary now that `no_dead_strip` is gone?
>> 
>> 
>> Repository:
>> rG LLVM Github Monorepo
>> 
>> CHANGES SINCE LAST ACTION
>> https://reviews.llvm.org/D70284/new/
>> 
>> https://reviews.llvm.org/D70284
>> 
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191119/c9f149c3/attachment.html>