<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto">Yup will do. <br><br><div dir="ltr">Sent from my iPhone<div><br></div><div><b>- Ben D. Jones</b></div></div><div dir="ltr"><br><blockquote type="cite">On Nov 19, 2019, at 6:32 PM, Akira Hatanaka <ahatanaka@apple.com> wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr"><span>Can you check the `#0` at the end of the globals and other strings that precede that? If you do so, we can also check that `no_dead_strip` isn’t added.</span><br><span></span><br><blockquote type="cite"><span>On Nov 19, 2019, at 6:05 PM, Duncan P. N. Exon Smith via Phabricator via cfe-commits <cfe-commits@lists.llvm.org> wrote:</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>dexonsmith added a comment.</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>For some reason this revision is locked down and I'm not allowed to "edit" it, which includes adding inline review comments. Can you add me as a reviewer?</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>The two comments:</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>- Please add a period at the end of the sentence in the comment.</span><br></blockquote><blockquote type="cite"><span>- Can you give more context about what `objc_arc_inert` is doing, and why it's necessary now that `no_dead_strip` is gone?</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>Repository:</span><br></blockquote><blockquote type="cite"><span> rG LLVM Github Monorepo</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>CHANGES SINCE LAST ACTION</span><br></blockquote><blockquote type="cite"><span> https://reviews.llvm.org/D70284/new/</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>https://reviews.llvm.org/D70284</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>_______________________________________________</span><br></blockquote><blockquote type="cite"><span>cfe-commits mailing list</span><br></blockquote><blockquote type="cite"><span>cfe-commits@lists.llvm.org</span><br></blockquote><blockquote type="cite"><span>https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</span><br></blockquote><span></span><br></div></blockquote></body></html>