[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

Tue Nov 19 14:42:32 PST 2019

eandrews added a comment.

In D69950#1752044 <https://reviews.llvm.org/D69950#1752044>, @gribozavr2 wrote:

> In D69950#1751894 <https://reviews.llvm.org/D69950#1751894>, @eandrews wrote:
>
> > In D69950#1751859 <https://reviews.llvm.org/D69950#1751859>, @gribozavr2 wrote:
> >
> > > > hence not throwing the warning on any platform?
> > >
> > > The way I read the buildbot breakage, an existing ClangTidy test passed before and after this change, but broke on Windows. The breakage was that the warnings stopped being produced.
> >
> >
> > The existing test does not have this warning. I modified the test to add the check for this warning since it is generated on Linux after my patch. It is not generated on Windows because of delayed template parsing.
>
>
> Is it just that warning that is not generated, or all warnings in that test file?

I am pretty sure it is just this warning but I will verify this again and push a new patch with "-fno-delayed-template-parsing" once I confirm . Thanks for all your help!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69950/new/

https://reviews.llvm.org/D69950