[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr2 added a comment.

In D69950#1751894 <https://reviews.llvm.org/D69950#1751894>, @eandrews wrote:

> In D69950#1751859 <https://reviews.llvm.org/D69950#1751859>, @gribozavr2 wrote:
>
> > > hence not throwing the warning on any platform?
> >
> > The way I read the buildbot breakage, an existing ClangTidy test passed before and after this change, but broke on Windows. The breakage was that the warnings stopped being produced.
>
>
> The existing test does not have this warning. I modified the test to add the check for this warning since it is generated on Linux after my patch. It is not generated on Windows because of delayed template parsing.


Is it just that warning that is not generated, or all warnings in that test file?

Anyhow, adding `-fno-delayed-template-parsing` to a ClangTidy test is not unreasonable, and is indeed existing practice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69950/new/

https://reviews.llvm.org/D69950