[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 19 04:51:29 PST 2019


JonasToth added a comment.

In D70390#1751159 <https://reviews.llvm.org/D70390#1751159>, @courbet wrote:

> > IMHO these two should just not overlap. It makes sense, to have controversial or configurable stuff in clang-tidy. It should just be consistent with the warnings, as those are "always right" and clang-tidy can be opinionated/specialized.
>
> So to make sure I understand you're advocating for keeping the `const` version in the clang-tidy check but removing the `&&` detection from this check and let the warning deal with that ?


Yes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70390/new/

https://reviews.llvm.org/D70390





More information about the cfe-commits mailing list