[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

Thu Nov 14 17:02:58 PST 2019

JonasToth added a comment.

In D70144#1745881 <https://reviews.llvm.org/D70144#1745881>, @poelmanc wrote:

> In D70144#1745583 <https://reviews.llvm.org/D70144#1745583>, @JonasToth wrote:
>
> > In D70144#1745532 <https://reviews.llvm.org/D70144#1745532>, @malcolm.parsons wrote:
> >
> > > Should `clang::format::cleanupAroundReplacements()` handle this instead?
> >
> >
> > Of yes. Totally forgot that. That would probably the most elegant way :)
>
>
> Interesting, so is the advantage of that approach that //any// fixit Replacement or Insertion that ends with a semicolon would have it removed if a semicolon already immediately follows it? That makes sense - one less thing for individual //check// developers to worry about.
>
> I can take a look at doing that.

Thinking about that: The cleanup should be called in general after clang-tidy runs. So it is weird, that it does not catch it.

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70144/new/

https://reviews.llvm.org/D70144