[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

Conrad Poelman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 14 09:02:11 PST 2019


poelmanc added a comment.

In D70144#1745583 <https://reviews.llvm.org/D70144#1745583>, @JonasToth wrote:

> In D70144#1745532 <https://reviews.llvm.org/D70144#1745532>, @malcolm.parsons wrote:
>
> > Should `clang::format::cleanupAroundReplacements()` handle this instead?
>
>
> Of yes. Totally forgot that. That would probably the most elegant way :)


Interesting, so is the advantage of that approach that //any// fixit Replacement or Insertion that ends with a semicolon would have it removed if a semicolon already immediately follows it? That makes sense - once less thing for individual check developers to worry about.

I can take a look at doing that.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70144/new/

https://reviews.llvm.org/D70144





More information about the cfe-commits mailing list