[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

Conrad Poelman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 13 16:40:31 PST 2019


poelmanc updated this revision to Diff 229202.
poelmanc added a comment.

Change to add just one helper function `findNextTokenSkippingComments` to `LexerUtils.h`, requiring no change to `Token::isOneOf`, and properly call it from `UseEqualsDefaultCheck.cpp`.

In D70144#1744737 <https://reviews.llvm.org/D70144#1744737>, @JonasToth wrote:

> Are you using the lexer-util functions? Maybe i am just to tired, but they seem to be unused.


Sorry, that was not you! I was experimenting with the `git show` command to generate these patches and failed to check the results closely. The correct calling code should be in the updated diff.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70144/new/

https://reviews.llvm.org/D70144

Files:
  clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp
  clang-tools-extra/clang-tidy/utils/LexerUtils.cpp
  clang-tools-extra/clang-tidy/utils/LexerUtils.h
  clang-tools-extra/docs/ReleaseNotes.rst
  clang-tools-extra/test/clang-tidy/checkers/modernize-use-equals-default-copy.cpp
  clang-tools-extra/test/clang-tidy/checkers/modernize-use-equals-default.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70144.229202.patch
Type: text/x-patch
Size: 6267 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191114/30c247a4/attachment-0001.bin>


More information about the cfe-commits mailing list