[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 13 13:56:28 PST 2019


JonasToth added a comment.

Are you using the lexer-util functions? Maybe i am just to tired, but they seem to be unused.



================
Comment at: clang/include/clang/Lex/Token.h:101
+  /// Single argument overload provides base case for recursive template below
+  bool isOneOf(tok::TokenKind K) const {
+    return is(K);
----------------
i would be rather against it. it is logically wrong as well, asl `isOneOf()` implies a choice.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70144/new/

https://reviews.llvm.org/D70144





More information about the cfe-commits mailing list