[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

Fri Nov 8 11:57:37 PST 2019

dblaikie added a comment.

In D69935#1738273 <https://reviews.llvm.org/D69935#1738273>, @uabelho wrote:

> Don't you need to also remove
>
>   case LinkageSpecDecl::lang_cxx_11:
>   case LinkageSpecDecl::lang_cxx_14:
>   
>
> from VisitLinkageSpecDecl in clang-tools-extra/modularize/Modularize.cpp? (added in r372714 / e07376a320d to silence a clang warning).
>  I can't see how that code would compile otherwise?

+1 to this & then it seems fine (probably without a committed test, but I wouldn't mind a copy/paste of clang's behavior before/after this patch posted to this review to demonstrate what is being fixed)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69935/new/

https://reviews.llvm.org/D69935