[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

Fri Nov 8 03:54:10 PST 2019

SouraVX added a comment.

In D69935#1738563 <https://reviews.llvm.org/D69935#1738563>, @ekatz wrote:

> In D69935#1738311 <https://reviews.llvm.org/D69935#1738311>, @SouraVX wrote:
>
> > I created that patch, for purpose of emitting C++ language standards C++11, C++14 in the debug information to be available for consumer's[GDB,LLDB]. 
> >  DW_TAG_lang_c_plus_plus_11 .. 14 --new tags for languages in DWARF5.
> >  Sorry, I think, I missed this unintended additions in LinkageSpecDecl.
> >
> > BTW, did you plan to completely revert this ??
>
>
> This is only a partial revert. It reverts only the part of the linkage languages. The other parts changed are untouched. You have also added a test, which should still pass.

Thank you! +1 from my side. I'm kinda still new here. So you can wait for acceptance from other reviewers.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69935/new/

https://reviews.llvm.org/D69935