[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

Fri Nov 1 08:40:43 PDT 2019

ymandel added a comment.

In D69625#1729702 <https://reviews.llvm.org/D69625#1729702>, @gribozavr2 wrote:

> > Which idiom do you think we should encourage, then, for text and range-selectors -- the named combinator or the single-argument cat? That is
>
> You are making a very interesting point!
>
> It sounds very appealing to me to remove the special `text` and `selection` functions in favor of `cat`. Users of the library (both readers and writers) will have to know about `cat`. So the advantage of having special functions `text` and `selection` is really limited I think.

Are you suggesting we remove `text` and `selection` entirely?  I really like this idea, just want to be sure I hadn't read more into your comment than you intended.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69625/new/

https://reviews.llvm.org/D69625