[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 31 20:00:16 PDT 2019


gribozavr2 added a comment.

> Which idiom do you think we should encourage, then, for text and range-selectors -- the named combinator or the single-argument cat? That is

You are making a very interesting point!

It sounds very appealing to me to remove the special `text` and `selection` functions in favor of `cat`. Users of the library (both readers and writers) will have to know about `cat`. So the advantage of having special functions `text` and `selection` is really limited I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69625/new/

https://reviews.llvm.org/D69625





More information about the cfe-commits mailing list