[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

Kadir Çetinkaya via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 31 05:23:22 PDT 2019


done. sorry for forgetting about this so soon.

On Thu, Oct 31, 2019 at 12:58 PM Nico Weber via Phabricator <
reviews at reviews.llvm.org> wrote:

> thakis added inline comments.
>
>
> ================
> Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1388
>    // results in arbitrary failures as function body becomes NULL.
>    ExtraArgs.push_back("-fno-delayed-template-parsing");
> +  for (const auto &Case : Cases)
> ----------------
> You might need something like this in some of the new tests.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D68937/new/
>
> https://reviews.llvm.org/D68937
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191031/e8435923/attachment.html>


More information about the cfe-commits mailing list