<div dir="ltr">done. sorry for forgetting about this so soon.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 31, 2019 at 12:58 PM Nico Weber via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">thakis added inline comments.<br>
<br>
<br>
================<br>
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1388<br>
   // results in arbitrary failures as function body becomes NULL.<br>
   ExtraArgs.push_back("-fno-delayed-template-parsing");<br>
+  for (const auto &Case : Cases)<br>
----------------<br>
You might need something like this in some of the new tests.<br>
<br>
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D68937/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D68937/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D68937" rel="noreferrer" target="_blank">https://reviews.llvm.org/D68937</a><br>
<br>
<br>
<br>
</blockquote></div>