[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

[Reid Kleckner via cfe-commits]

On Mon, Oct 28, 2019 at 4:42 PM David Blaikie via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> If the intended behavior is to show the crash at the call site like
>> LangRef in the patch suggest then line 0 will certainly not achieve that. I
>> implicitly assumed the wording in LangRef would follow the implementation
>> if we switched to line 0.
>>
>
> Right - I think there's some reasonable discussion about what would be
> suitable/useful behavior - and line zero isn't necessarily an experience a
> user would want in this situation. (if there's no user for the feature, why
> build it - if we have a quality/space tradeoff that seems useful to
> CodeView users & we know inlining info is expensive in DWARF too (maybe not
> as expensive as CodeView, I'm not sure) & so DWARF users /might/ want the
> same tradeoff, seems like it might be worth providing the same
> feature/behavior in both)
>
> Put another way: I don't know/don't think Reid's users would want the
> feature using line zero even if CV had support for something equivalent to
> DWARF's line zero. The "attribute it to the call site" behavior is more
> meaningful/useful than line zero to a user.
>

Right, what you said here is what I was trying to express clearly. Thanks.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191029/f1af895d/attachment-0001.html>