[PATCH] D69494: OpenMP: Add helper function for convergent runtime calls

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added a comment.

In D69494#1722868 <https://reviews.llvm.org/D69494#1722868>, @ABataev wrote:

> In D69494#1722867 <https://reviews.llvm.org/D69494#1722867>, @arsenm wrote:
>
> > In D69494#1722853 <https://reviews.llvm.org/D69494#1722853>, @ABataev wrote:
> >
> > > Tests?
> >
> >
> >
> >
> > In D69494#1722853 <https://reviews.llvm.org/D69494#1722853>, @ABataev wrote:
> >
> > > Tests?
> >
> >
> > This is NFC and doesn't change any behavior. The test for the convergent attribute is already handled in nvptx_parallel_codegen.cpp
>
>
> Nope, you're narking some calls withe the new attribute. It is not NFC in this case.


More precisely, this is marking the function declarations with the attribute. These were already marked with the attribute. This just moves it into the helper function. D69495 <https://reviews.llvm.org/D69495> adds new instances of the attribute


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69494/new/

https://reviews.llvm.org/D69494