[PATCH] D69494: OpenMP: Add helper function for convergent runtime calls

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Oct 27 19:13:06 PDT 2019


ABataev added a comment.

In D69494#1722867 <https://reviews.llvm.org/D69494#1722867>, @arsenm wrote:

> In D69494#1722853 <https://reviews.llvm.org/D69494#1722853>, @ABataev wrote:
>
> > Tests?
>
>
>
>
> In D69494#1722853 <https://reviews.llvm.org/D69494#1722853>, @ABataev wrote:
>
> > Tests?
>
>
> This is NFC and doesn't change any behavior. The test for the convergent attribute is already handled in nvptx_parallel_codegen.cpp


Nope, you're narking some calls withe the new attribute. It is not NFC in this case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69494/new/

https://reviews.llvm.org/D69494





More information about the cfe-commits mailing list