[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 24 10:45:05 PDT 2019


MyDeveloperDay added a comment.

Thank you for the patch,  I wrote this checker originally and this LGTM.

I'm not sure if others have any objections to using "using clang::attr::WarnUnusedResult" in the body of the function, I couldn't see this pattern used elsewhere in clang-tidy, all I've seen is it being used in ClangTidyOptions.cpp globally.

I'd wait for some more feedback from the main owners, but thank you and welcome.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69388/new/

https://reviews.llvm.org/D69388





More information about the cfe-commits mailing list