[PATCH] D69389: [hip] Relax an allow the declaration of functions with variadic arguments in HIP.

Michael Liao via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 24 08:59:52 PDT 2019


hliao created this revision.
hliao added reviewers: jlebar, tra, yaxunl.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

- As variadic parameters have the lowest rank in overload resolution, without real usage of `va_arg`, they are commonly used as the catch-all fallbacks in SFINAE. As the front-end still reports errors on calls to `va_arg`, the declaration of functions with variadic arguments should be allowed in general.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69389

Files:
  clang/lib/CodeGen/TargetInfo.cpp
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/lib/Driver/ToolChains/HIP.cpp
  clang/test/Driver/hip-toolchain-no-rdc.hip
  clang/test/Driver/hip-toolchain-rdc.hip

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69389.226273.patch
Type: text/x-patch
Size: 5555 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191024/0031c572/attachment.bin>


More information about the cfe-commits mailing list