[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 11 13:53:37 PDT 2019


NoQ marked 2 inline comments as done.
NoQ added a comment.

In D67381#1665930 <https://reviews.llvm.org/D67381#1665930>, @Szelethus wrote:

> Side note, now that you had to work with the freshly rewritten file, do you have any feedback on it?


Dunno, i'm a very functional / pure / stateless person. "I debugged, I edited, I forgot <https://en.wikipedia.org/wiki/Veni,_vidi,_vici>". "I suffer from short-term memory loss <https://reviews.llvm.org/D32592?id=97060#inline-291980>".

But given that it was fairly easy for me to focus on the task at hand and this whole thing was definitely not traumatizing, i suspect that the file ended up in a fairly good shape and i can't complain.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67381/new/

https://reviews.llvm.org/D67381





More information about the cfe-commits mailing list