[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

Wed Sep 11 10:56:53 PDT 2019

NoQ marked an inline comment as done.
NoQ added inline comments.

================
Comment at: clang/lib/StaticAnalyzer/Core/PathDiagnostic.cpp:34
 #include "clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h"
-#include "clang/StaticAnalyzer/Core/PathSensitive/SVals.h"
 #include "llvm/ADT/ArrayRef.h"
----------------
Szelethus wrote:
> Nice, how did you catch this? Some compiler warning?
No, it's just that removing these includes is the whole point of the patch. In order to be able to move this file out of static analyzer, it should not include headers from static analyzer. This patch removes one such include.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67381/new/

https://reviews.llvm.org/D67381