[PATCH] D67277: [clangd] Replace HighlightingKind::NumKinds with LastKind. NFC
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 9 01:39:08 PDT 2019
ilya-biryukov added a comment.
In D67277#1662669 <https://reviews.llvm.org/D67277#1662669>, @hokein wrote:
> LGTM, though I think the current implementation is a common pattern.
Thanks.
It's indeed a common pattern. The problem is that it forces clients to handle this extra case in every switch statement (otherwise we get compiler warnings).
`LastKind` avoids this, therefore it's arguably a little better for the clients.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67277/new/
https://reviews.llvm.org/D67277
More information about the cfe-commits
mailing list