[PATCH] D67277: [clangd] Replace HighlightingKind::NumKinds with LastKind. NFC

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 9 01:35:59 PDT 2019

Previous message: [PATCH] D67274: [clangd] Improve output of semantic highlighting tests in case of failures
Next message: [PATCH] D67277: [clangd] Replace HighlightingKind::NumKinds with LastKind. NFC
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

LGTM, though I think the current implementation is a common pattern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67277/new/

https://reviews.llvm.org/D67277

Previous message: [PATCH] D67274: [clangd] Improve output of semantic highlighting tests in case of failures
Next message: [PATCH] D67277: [clangd] Replace HighlightingKind::NumKinds with LastKind. NFC
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the cfe-commits mailing list