[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 5 09:10:53 PDT 2019


dexonsmith added a comment.

I don't think you need prior frontend expertise, just some time and patience since the modules code has some technical debt.  If you are still willing to look at it, I agree with Richard's suggestion that we could merge this with the map in the Module Manager.  One approach would be to start caching (and invalidating?) module load failures in the ModuleManager somehow, redirect APIs using KnownModules to point there, and then delete this cache entirely.  Another approach would be to re-evaluate if we need to cache module load failures; hypothetically, it's possible we don't need that feature (anymore).


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58497/new/

https://reviews.llvm.org/D58497





More information about the cfe-commits mailing list