[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

[Nemanja Ivanovic via Phabricator via cfe-commits]

nemanjai added a comment.

I have not seen this problem resurface to be honest. When we initially hit it, changing the path for the build worked around the problem for us so we weren't really hitting in any longer. I posted this because I realized the possibility exists of having these dangling pointers (and it certainly fixed our original problem even without changing the build path).
However, I must say that I am completely out of my depth here as I am not a front end developer and don't really know how any of this stuff is supposed to work (i.e. whether it makes sense for `PP` here to be pointing to something that will go away).

That being said, I am perfectly happy to do what the experts suggest here, including abandoning the patch, updating it as requested, etc.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58497/new/

https://reviews.llvm.org/D58497