[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

[Puyan Lotfi via Phabricator via cfe-commits]

plotfi marked 4 inline comments as done.
plotfi added inline comments.


================
Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:383
+            auto VD = cast<ValueDecl>(E.first)->getType();
+            OS << "Object, Size: "
+               << context.getTypeSizeInChars(VD).getQuantity();
----------------
compnerd wrote:
> Why is this comma separated rather than a separate value?
Vestiges of TBE elfabi inspiration. It can change in experimental-ifs-v2 / 1.1 or something.


================
Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:392
+          if (Symbol.Binding == llvm::ELF::STB_WEAK)
+            OS << ", Weak: true";
+          OS << " }\n";
----------------
compnerd wrote:
> Why comma separated rather than new KV pair?
Vestiges of TBE elfabi inspiration. It can change in experimental-ifs-v2 / 1.1 or something.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66446/new/

https://reviews.llvm.org/D66446