[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

[Saleem Abdulrasool via Phabricator via cfe-commits]

compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

Please add a test case for read/write, otherwise LGTM.



================
Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:383
+            auto VD = cast<ValueDecl>(E.first)->getType();
+            OS << "Object, Size: "
+               << context.getTypeSizeInChars(VD).getQuantity();
----------------
Why is this comma separated rather than a separate value?


================
Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:392
+          if (Symbol.Binding == llvm::ELF::STB_WEAK)
+            OS << ", Weak: true";
+          OS << " }\n";
----------------
Why comma separated rather than new KV pair?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66446/new/

https://reviews.llvm.org/D66446