[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

Dávid Bolvanský via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 19 13:39:38 PDT 2019


xbolva00 added a comment.

>> suggested source-code fixit of #define ALPHA_OFFSET 0x3

No, there is a note “replace with 0x2 ^ ALPHA_OFFSET” to silence it.

While we can suggest as you wrote:
#define ALPHA_OFFSET 0x3

I really dont think it is worth to do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66397/new/

https://reviews.llvm.org/D66397





More information about the cfe-commits mailing list