[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow
Arthur O'Dwyer via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 19 13:29:55 PDT 2019
Quuxplusone added a comment.
In D66397#1635796 <https://reviews.llvm.org/D66397#1635796>, @xbolva00 wrote:
> Now, Chromium disabled this warning :( until we “fix” it.
If Chromium is willing to make build-system changes to add `-Wno-xor-as-pow`, then surely they should also be willing to make the suggested source-code fixit of `#define ALPHA_OFFSET 0x3` where hexadecimal indicates an intentional bitwise operation. Let's give them a little time to react to that suggestion. :)
(A heavier workaround would be to use `xor` instead of `^`.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66397/new/
https://reviews.llvm.org/D66397
More information about the cfe-commits
mailing list