[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases
Saleem Abdulrasool via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Aug 10 21:35:46 PDT 2019
compnerd added inline comments.
================
Comment at: clang/include/clang/Driver/Types.h:107
+ llvm::opt::DerivedArgList &DAL, ID Id,
+ llvm::SmallVectorImpl<phases::ID> &Phases);
----------------
This really makes things confusing, perhaps renaming `getCompilationPhases` to `getCompletePhaseList` or something might make it less confusing? Although, I suppose that you do have follow up patches to improve this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65993/new/
https://reviews.llvm.org/D65993
More information about the cfe-commits
mailing list