[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

Puyan Lotfi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 10 14:08:13 PDT 2019


plotfi marked 5 inline comments as done.
plotfi added inline comments.


================
Comment at: clang/lib/Driver/Types.cpp:11
+#include "clang/Driver/Options.h"
+#include "clang/Driver/DriverDiagnostic.h"
 #include "clang/Driver/Types.h"
----------------
aaron.ballman wrote:
> Can you sort these includes?
sorted.


================
Comment at: clang/lib/Driver/Types.cpp:309
+      DAL.getLastArg(options::OPT_M, options::OPT_MM) ||
+      DAL.getLastArg(options::OPT__SLASH_P)) {
+    // Filter to compiler mode. When the compiler is run as a preprocessor then
----------------
aaron.ballman wrote:
> You can elide braces for all of the `if` statement bodies here.
elided


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65993/new/

https://reviews.llvm.org/D65993





More information about the cfe-commits mailing list