[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:3326
+    types::getCompilationPhases(*this, Args, InputType, PL);
+    if (!PL.size())
       continue;
----------------
`PL.empty()` instead


================
Comment at: clang/lib/Driver/Types.cpp:11
+#include "clang/Driver/Options.h"
+#include "clang/Driver/DriverDiagnostic.h"
 #include "clang/Driver/Types.h"
----------------
Can you sort these includes?


================
Comment at: clang/lib/Driver/Types.cpp:309
+      DAL.getLastArg(options::OPT_M, options::OPT_MM) ||
+      DAL.getLastArg(options::OPT__SLASH_P)) {
+    // Filter to compiler mode. When the compiler is run as a preprocessor then
----------------
You can elide braces for all of the `if` statement bodies here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65993/new/

https://reviews.llvm.org/D65993