[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases
Puyan Lotfi via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 9 11:12:25 PDT 2019
plotfi marked an inline comment as done.
plotfi added inline comments.
================
Comment at: clang/lib/Driver/Driver.cpp:3220
- phases::ID FinalPhase;
{
Arg *FinalPhaseArg;
----------------
@aaron.ballman How's this look to you now? I have another NFC patch coming up that will move this entire block into its a separate function. I think finally this Drive::BuildActions code can have the code that handles and does things with various arguments separate from the actual job phase pipeline setup code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65993/new/
https://reviews.llvm.org/D65993
More information about the cfe-commits
mailing list