[PATCH] D65828: [clang-tidy] Add check to linuxkernel for unbalanced irq calls

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/linuxkernel/IrqUnbalancedCheck.cpp:13
+
+std::string annotation = "ignore_irq_balancing";
+
----------------
Should be static and may be StringRef?


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:79
+
+  Checks Linux kernel for dangerous uses of ``local_irq_disable`` and ``local_irq_enable``
+
----------------
Please add dot at the end. Probably// Linux kernel// is redundant because of check name.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:87
 
 
+
----------------
Please remove two empty lines.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/linuxkernel-irq-unbalanced.rst:6
+
+Checks for calls to ``local_irq_disable`` without matching calls to ``local_irq_enable``
+and vice-versa. In most cases these functions must be called in pairs to avoid indefinite
----------------
Please make first statement same as In Release Notes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65828/new/

https://reviews.llvm.org/D65828